refactor: remove RSA encryption from Binance travel rule#329
Merged
monsieurleberre merged 4 commits intodevfrom Feb 17, 2026
Merged
Conversation
Contributor
Author
|
@claude please review this PR. Focus on:
|
Contributor
Author
|
plot twist!! 
|
monsieurleberre
deleted the
chore/cleanup-travel-rule-encryption-useless-implementation
branch
monsieurleberre
added a commit
that referenced
this pull request
Feb 18, 2026
* Add Binance Travel Rule support with PII encryption (#328) This is sub production level, OK, and breaking the build, but this is just a trace, and next commit will remove all the 💩 * refactor: remove RSA encryption from Binance travel rule (#329) * refactor: remove RSA encryption from Binance travel rule * Unbreak the build 🤞 * OK this time we fix the build 🙈 * revert ExchangeAccountsClientTests to 5cddfcf * Chore/just put the encryption back the fun never ends (#331) * add Binance Travel Rule support with PII encryption * refactor: remove beneficiaryVASP and consolidate travel rule tests * Sorry I missed this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the speculative RSA encryption layer from Binance travel rule PII data. Binance requires plain-text PII, so the encryption service, cached public key, and encrypted payload construction were unnecessary complexity.
Changes
IRsaEncryptionService,RsaEncryptionService, andRsaEncryptionServiceTestsBinanceTravelRuleServiceto use plain-text values for both withdrawal and depositbeneficiaryVASPsection andIExchange_accountsClientdependencyTesting