Skip to content

✅ Fix function names in WETH tests #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
transmissions11 merged 1 commit into from
Jun 22, 2022
Merged

✅ Fix function names in WETH tests #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .gas-snapshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ ERC20Test:testApprove() (gas: 31058)
ERC20Test:testBurn() (gas: 56970)
ERC20Test:testFailPermitBadDeadline() (gas: 36924)
ERC20Test:testFailPermitBadNonce() (gas: 36874)
ERC20Test:testFailPermitPastDeadline() (gas: 10938)
ERC20Test:testFailPermitPastDeadline() (gas: 8589)
ERC20Test:testFailPermitReplay() (gas: 66285)
ERC20Test:testFailTransferFromInsufficientAllowance() (gas: 80882)
ERC20Test:testFailTransferFromInsufficientBalance() (gas: 81358)
Expand Down Expand Up @@ -216,7 +216,7 @@ SafeTransferLibTest:testTransferWithMissingReturn() (gas: 36669)
SafeTransferLibTest:testTransferWithNonContract() (gas: 3012)
SafeTransferLibTest:testTransferWithReturnsTooMuch() (gas: 37115)
SafeTransferLibTest:testTransferWithStandardERC20() (gas: 36699)
WETHTest:testDeposit() (gas: 63260)
WETHTest:testFallbackDeposit() (gas: 63524)
WETHTest:testDeposit() (gas: 63535)
WETHTest:testFallbackDeposit() (gas: 63249)
WETHTest:testPartialWithdraw() (gas: 73281)
WETHTest:testWithdraw() (gas: 54360)
8 changes: 4 additions & 4 deletions src/test/WETH.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ contract WETHTest is DSTestPlus {
weth = new WETH();
}

function testDeposit() public {
function testFallbackDeposit() public {
assertEq(weth.balanceOf(address(this)), 0);
assertEq(weth.totalSupply(), 0);

Expand All @@ -25,7 +25,7 @@ contract WETHTest is DSTestPlus {
assertEq(weth.totalSupply(), 1 ether);
}

function testFallbackDeposit() public {
function testDeposit() public {
assertEq(weth.balanceOf(address(this)), 0);
assertEq(weth.totalSupply(), 0);

Expand Down Expand Up @@ -63,7 +63,7 @@ contract WETHTest is DSTestPlus {
assertEq(weth.totalSupply(), 0.5 ether);
}

function testDeposit(uint256 amount) public {
function testFallbackDeposit(uint256 amount) public {
amount = bound(amount, 0, address(this).balance);

assertEq(weth.balanceOf(address(this)), 0);
Expand All @@ -75,7 +75,7 @@ contract WETHTest is DSTestPlus {
assertEq(weth.totalSupply(), amount);
}

function testFallbackDeposit(uint256 amount) public {
function testDeposit(uint256 amount) public {
amount = bound(amount, 0, address(this).balance);

assertEq(weth.balanceOf(address(this)), 0);
Expand Down