✅ Add safeCastTo16 #311
Merged
✅ Add safeCastTo16 #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| SafeCastLib.safeCastTo24(x); | ||
| } | ||
|
|
||
| function testFailSafeCastTo16(uint256 x) public { |
Owner
There was a problem hiding this comment.
missing a testSafeCastTo16
Contributor
Author
There was a problem hiding this comment.
https://github.com/transmissions11/solmate/pull/311/files#diff-1cf1e7c9ff842ab06001df49e0dae514a7141c6626a24ca4f5cafd887b4d4d09R54 ? or am i an idiot and completely misunderstanding
Owner
There was a problem hiding this comment.
you've got a concrete success test, but need a successful fuzz test too hehe
Contributor
Author
There was a problem hiding this comment.
i hate when i'm an idiot - added the test
robertabbott
force-pushed
the
bobby-safe-to-16
branch
from
0b5c838 to
0fa6788
Compare
robertabbott
force-pushed
the
bobby-safe-to-16
branch
from
0fa6788 to
f495738
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds safeCastTo16
Checklist
forge snapshot?npm run lint?forge test?