Conversation
jiggoha
changed the title
jiggoha
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
=======================================
Coverage 55.99% 55.99%
=======================================
Files 8 8
Lines 759 759
=======================================
Hits 425 425
Misses 265 265
Partials 69 69 ☔ View full report in Codecov by Sentry. |
jiggoha
force-pushed
the
precondition
branch
from
c5b0dcc to
5039863
Compare
mhutchinson
approved these changes
Jan 3, 2024
Contributor
Author
|
The force-pushing was some non-elegant rebasing onto main. I deployed to some dev functions on GCF to test this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After this PR, the Integrate function may fail if the generation precondition of the new checkpoint does not match the last read checkpoint.
To tighten that, we should add a retry policy for the Cloud Build step (e.g. here) to Integrate a new log entry.