initial snap support#1122
Merged
Merged
Conversation
added 3 commits
October 15, 2019 19:41
`snapcraft login --with` assumes a file input unless using the special argument '-' to read from stdin. Echo the token to snapcraft using `snapcraft login --with -`. Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- Build test snap which just prints a string derived from ID. - Deploy test snap to edge channel. - Install test snap from snap store. - Run installed snap, ensures output matches expected. Note that LXD is required for snapcraft to build, and there is some setup required for proper operation. Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
Contributor
|
awesome, thank you @cjp256! 🎉 i'm going to merge this. let's discuss handoff etc on Slack. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to fix and test snap deployment.
Before merging, this will require a handoff or collaborative access for:
(1)
dee-pee-ell-testsnap(2) or
sed -i 's|dee-pee-ell-test|dpl-test|g'to usedpl-testsnap which I believe is owned by @svenfuchs.SNAP_TOKEN may be generated using snapcraft with:
snapcraft export-login --acls package_upload --snaps <snap-name> --channels edge -