Skip to content

Fix flaky test: Set a error margin to make test robust#231

Merged
exoego merged 1 commit intomasterfrom
230-flaky-test
Jan 27, 2023
Merged

Fix flaky test: Set a error margin to make test robust#231
exoego merged 1 commit intomasterfrom
230-flaky-test

Conversation

@exoego
Copy link
Contributor

@exoego exoego commented Jan 27, 2023

Closes #230

@exoego exoego marked this pull request as ready for review January 27, 2023 05:11
Copy link
Contributor

@yuokada yuokada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. LGTM. ✅

@exoego exoego merged commit 835d5f2 into master Jan 27, 2023
@exoego exoego deleted the 230-flaky-test branch January 27, 2023 06:16
@exoego exoego added the chore internal changes (not user-facing) label Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore internal changes (not user-facing)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky test: TestTDHttpClient#retryOn429

2 participants