Conversation
This reverts commit 120312b.
xerial
approved these changes
Sep 14, 2023
xerial
reviewed
Sep 14, 2023
| executors: | ||
| jdk8: | ||
| docker: | ||
| - image: cimg/openjdk:8.0 |
Member
There was a problem hiding this comment.
If we are going to support jdk8 (I think we can move to JDK11, though), adding --release 8 javac option will be helpful for enforcing JDK8 support
Contributor
Author
There was a problem hiding this comment.
Thanks for your advice. I will consider adding it when bumping the minimum JDK to 11.
xerial
reviewed
Sep 14, 2023
| private static final String SAMPLE_DB = "_tdclient_test"; | ||
| private static final String SAMPLE_DB; | ||
| static { | ||
| SAMPLE_DB = "_tdclient_test" + System.getProperty("java.version").replaceAll("\\.", "_"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.