Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for TRINO queries by introducing new factory methods in the TDJobRequest class and updating the TDJob Type enumeration.
- Added three overloaded versions of newTrinoQuery in TDJobRequest.java.
- Updated TDJob.java to include the new TRINO type for job requests.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main/java/com/treasuredata/client/model/TDJobRequest.java | Adds overloaded newTrinoQuery methods for constructing TRINO job requests. |
| src/main/java/com/treasuredata/client/model/TDJob.java | Adds TRINO enumerator to the job type enum to support TRINO queries. |
Comments suppressed due to low confidence (2)
src/main/java/com/treasuredata/client/model/TDJobRequest.java:113
- Add Javadoc comments to explain the purpose and differences between the overloaded newTrinoQuery methods, similar to the existing query methods.
public static TDJobRequest newTrinoQuery(String database, String query)
src/main/java/com/treasuredata/client/model/TDJobRequest.java:122
- Ensure there are corresponding tests that validate the behavior of each newTrinoQuery overload for proper functionality.
public static TDJobRequest newTrinoQuery(String database, String query, String resultOutput)
tung-vu-td
reviewed
Jun 13, 2025
Contributor
tung-vu-td
left a comment
tung-vu-td
left a comment
There was a problem hiding this comment.
You may want to add some tests 😌
nmpennypacker
approved these changes
Jun 18, 2025
nmpennypacker
left a comment
nmpennypacker
left a comment
There was a problem hiding this comment.
Reviewed for data exfiltrations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.