Remove include_v flag support from table operations#157
Open
xuantuan58 wants to merge 1 commit intomasterfrom
Open
Remove include_v flag support from table operations#157xuantuan58 wants to merge 1 commit intomasterfrom
xuantuan58 wants to merge 1 commit intomasterfrom
Conversation
- Remove include_v parameter from table creation and update methods - Remove include_v attribute from Table model class - Update table listing to exclude include_v field - Clean up related test cases for include_v functionality - Remove documentation references to include_v parameter
There was a problem hiding this comment.
Pull Request Overview
This pull request removes support for the deprecated include_v flag from table operations across the TreasureData client library. The include_v parameter was related to the v column feature that was deprecated when Hive 0.13 was retired.
- Removed
include_vparameter fromcreate_log_tableandupdate_tablemethod signatures and documentation - Updated the
Tablemodel to eliminateinclude_vattribute from initialization and accessor methods - Modified table listing logic to exclude
include_vprocessing from API responses
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| spec/td/client/table_api_spec.rb | Updated tests to use expire_days instead of include_v and removed dedicated include_v test suite |
| lib/td/client/model.rb | Removed include_v parameter from Table model initialization and attr_reader |
| lib/td/client/api/table.rb | Eliminated include_v processing from table listing and removed parameter documentation |
| lib/td/client.rb | Removed include_v from method signatures and updated table instantiation calls |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
nmpennypacker
approved these changes
Aug 29, 2025
nmpennypacker
left a comment
There was a problem hiding this comment.
Reviewed for data exfiltrations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As v column feature was deprecated when hive 0.13 was retired. We will clean up resources related to v column, which are no longer used.
This pull request removes all handling of the
include_vflag from the table management API and related code. The changes simplify the codebase by eliminating theinclude_vparameter from method signatures, data structures, and tests, focusing table creation and updates on theexpire_daysanddetect_schemaparameters instead.API and Model Simplification:
include_vparameter from the signatures and documentation ofcreate_log_tableandupdate_tablemethods inlib/td/client.rbandlib/td/client/api/table.rb. [1] [2] [3]Tablemodel to remove theinclude_vattribute from its initializer andattr_readerlist, and stopped passing or storing this value. [1] [2] [3]include_vvalue from API responses. [1] [2]Test Updates:
expire_daysparameter instead ofinclude_vand removed all references toinclude_vin test expectations. [1] [2]include_vflag, as this functionality is no longer present.- Remove include_v parameter from table creation and update methods