Skip to content

Remove include_v flag support from table operations#157

Open
xuantuan58 wants to merge 1 commit intomasterfrom
remove_v_column
Open

Remove include_v flag support from table operations#157
xuantuan58 wants to merge 1 commit intomasterfrom
remove_v_column

Conversation

@xuantuan58
Copy link
Contributor

As v column feature was deprecated when hive 0.13 was retired. We will clean up resources related to v column, which are no longer used.

This pull request removes all handling of the include_v flag from the table management API and related code. The changes simplify the codebase by eliminating the include_v parameter from method signatures, data structures, and tests, focusing table creation and updates on the expire_days and detect_schema parameters instead.

API and Model Simplification:

  • Removed the include_v parameter from the signatures and documentation of create_log_table and update_table methods in lib/td/client.rb and lib/td/client/api/table.rb. [1] [2] [3]
  • Updated the Table model to remove the include_v attribute from its initializer and attr_reader list, and stopped passing or storing this value. [1] [2] [3]
  • Adjusted the table listing logic to no longer expect or process the include_v value from API responses. [1] [2]

Test Updates:

  • Updated table creation tests to use the expire_days parameter instead of include_v and removed all references to include_v in test expectations. [1] [2]
  • Removed the test suite for handling the include_v flag, as this functionality is no longer present.- Remove include_v parameter from table creation and update methods

- Remove include_v parameter from table creation and update methods
- Remove include_v attribute from Table model class
- Update table listing to exclude include_v field
- Clean up related test cases for include_v functionality
- Remove documentation references to include_v parameter
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request removes support for the deprecated include_v flag from table operations across the TreasureData client library. The include_v parameter was related to the v column feature that was deprecated when Hive 0.13 was retired.

  • Removed include_v parameter from create_log_table and update_table method signatures and documentation
  • Updated the Table model to eliminate include_v attribute from initialization and accessor methods
  • Modified table listing logic to exclude include_v processing from API responses

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
spec/td/client/table_api_spec.rb Updated tests to use expire_days instead of include_v and removed dedicated include_v test suite
lib/td/client/model.rb Removed include_v parameter from Table model initialization and attr_reader
lib/td/client/api/table.rb Eliminated include_v processing from table listing and removed parameter documentation
lib/td/client.rb Removed include_v from method signatures and updated table instantiation calls

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@tung-vu-td tung-vu-td left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tung-vu-td tung-vu-td requested a review from a team August 29, 2025 03:13
Copy link

@nmpennypacker nmpennypacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed for data exfiltrations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants