Skip to content

parseSvg: accept either a string or XmlNode as input #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ghost wants to merge 1 commit into from
Closed

parseSvg: accept either a string or XmlNode as input #533

ghost wants to merge 1 commit into from

Conversation

@ghost
Copy link

@ghost ghost commented Apr 3, 2023

No description provided.

@ghost
Copy link
Author

ghost commented Jul 6, 2023

There is already exists as proc parseSvg(data: string | XmlNode, width, height: int): Svg but the body of the proc won't actually compile for XmlNode.

@treeform
Copy link
Owner

treeform commented Nov 16, 2024

Thank you for the PR, I made some changes here: #556

@ghost ghost closed this Nov 23, 2024
@ghost ghost deleted the xmltree branch November 23, 2024 22:15
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@treeform