Skip to content

hashfile: drop default dos2unix behavior#362

Merged
pmrowla merged 2 commits into
treeverse:mainfrom
pmrowla:drop-dos2unix
Jun 9, 2023
Merged

hashfile: drop default dos2unix behavior#362
pmrowla merged 2 commits into
treeverse:mainfrom
pmrowla:drop-dos2unix

Conversation

@pmrowla
Copy link
Copy Markdown
Contributor

@pmrowla pmrowla commented Jun 1, 2023

  • old dos2unix detected text heuristics behavior is now only done explicitly when hash name is md5-dos2unix
  • the default md5 hash is now real MD5, with no dos2unix text handling
  • removes automatic text detection (hash_file(text=...)) API
    • removes --text and --binary options from CLI hashing utility

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 6, 2023

Codecov Report

Patch coverage: 70.68% and project coverage change: +0.01 🎉

Comparison is base (5377d63) 61.10% compared to head (8df182e) 61.12%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #362      +/-   ##
==========================================
+ Coverage   61.10%   61.12%   +0.01%     
==========================================
  Files          54       54              
  Lines        3664     3694      +30     
  Branches      653      659       +6     
==========================================
+ Hits         2239     2258      +19     
- Misses       1294     1303       +9     
- Partials      131      133       +2     
Impacted Files Coverage Δ
src/dvc_data/hashfile/build.py 17.32% <0.00%> (ø)
src/dvc_data/index/save.py 76.47% <0.00%> (ø)
src/dvc_data/hashfile/state.py 32.55% <20.00%> (-1.33%) ⬇️
src/dvc_data/cli.py 31.65% <50.00%> (ø)
src/dvc_data/hashfile/tree.py 55.12% <63.63%> (+0.01%) ⬆️
src/dvc_data/hashfile/hash.py 78.18% <95.83%> (+2.42%) ⬆️
tests/hashfile/test_hash.py 100.00% <100.00%> (ø)
tests/hashfile/test_hash_stream.py 100.00% <100.00%> (ø)
tests/hashfile/test_tree.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pmrowla pmrowla marked this pull request as ready for review June 8, 2023 07:18
@pmrowla pmrowla force-pushed the drop-dos2unix branch 2 times, most recently from d1b2d40 to 567028c Compare June 9, 2023 09:01
@pmrowla pmrowla merged commit 7fbce6a into treeverse:main Jun 9, 2023
@pmrowla pmrowla deleted the drop-dos2unix branch June 9, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants