glossary: soft code style constants in tooltip file

[algomaster99]

Soft code all style constants inside state.
https://github.com/iterative/dvc.org/blob/c049220f41616384cb85e695af869056c8e82e32/src/Tooltip/index.js#L11

[jorgeorpinel]

Do you mean creating a glossary.json config file to load these from? Or maybe in the same glossary.js file?

[algomaster99]

@shcheklein What do you suggest?

[shcheklein]

@jorgeorpinel I'm not sure I got the question tbh.

[jorgeorpinel]

Do you mean creating a glossary.json config file to load these from? Or maybe in the same glossary.js file?

I was asking Aman to confirm the meaning of this issue. And assuming I understand it correctly, suggesting to use the existing glossary.js file for this.

[jorgeorpinel]

@algomaster99 hi! I'm seeing a bunch of style-related values in the state of the main component in src/Tooltip/desktop-view.js . Is this what you meant? What is the advantage of doing this vs. just hardcoding the values in the styled components instead? Thanks

[algomaster99]

@jorgeorpinel hello! Since there are too many constants, I thought softcoding and explaining them through comments could be beneficial. 😅

[jorgeorpinel]

Thank you, makes sense.

@shcheklein given that this issue is for a refactoring and we're looking into Gatsby rather now, should we close or remove the priority? Thanks

UPDATE: Oh wait I already did remote the priority haha. I don't remember doing that...