Fix typo and missing line in define-ml-pipeline.md#1003
Merged
Conversation
Contributor
jorgeorpinel
left a comment
jorgeorpinel
left a comment
There was a problem hiding this comment.
Thanks Matteo. I may further edit this per comments below but definitely needed a review!
| 1. DVC transforms all the outputs (`-o` option) into tracked data files (similar | ||
| to using `dvc add` for each of them). As a result, all the actual data | ||
| contents goes to the <abbr>cache</abbr> directory `.dvc/cache`, and each of | ||
| content goes to the <abbr>cache</abbr> directory `.dvc/cache`, and each of |
Contributor
There was a problem hiding this comment.
Maybe "data contents go"
|
|
||
| The result of the last three `dvc run` commands execution is three stage files | ||
| and a modified .gitignore file. All the changes should be committed into Git: | ||
| and a modified .gitignore file. All the changes should be committed to Git: |
jorgeorpinel
added a commit
that referenced
this pull request
Feb 18, 2020
Merged
Contributor
|
Addressing ^ in #1005 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.
🐛 Please make sure to mention
Fix #issue(if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.Please chose to allow us to edit your branch when creating the PR.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏