cmd ref: add list command#1021
Merged
Merged
Conversation
Closed
shcheklein
reviewed
Feb 25, 2020
shcheklein
reviewed
Feb 25, 2020
shcheklein
reviewed
Feb 25, 2020
shcheklein
reviewed
Feb 25, 2020
shcheklein
reviewed
Feb 25, 2020
shcheklein
reviewed
Feb 25, 2020
shcheklein
suggested changes
Feb 25, 2020
Contributor
shcheklein
left a comment
shcheklein
left a comment
There was a problem hiding this comment.
Guro, looks good. PTAL and address some comments that make sense to you. Otherwise it is in a good shape that we can take and iterate on it. Thanks.
shcheklein
suggested changes
Feb 26, 2020
Contributor
shcheklein
left a comment
shcheklein
left a comment
There was a problem hiding this comment.
Thanks, @JIoJIaJIu ! We'll take this over 👍
jorgeorpinel
reviewed
Mar 3, 2020
jorgeorpinel
reviewed
Mar 4, 2020
jorgeorpinel
reviewed
Mar 4, 2020
Contributor
|
Contributor
|
I rewrote the fist half @shcheklein. Please check when you can and I'll address your feedback at that time along with a review of the examples. Hoping we also get answers to the few questions I added above by then. Thanks! |
This comment has been minimized.
This comment has been minimized.
Contributor
|
@jorgeorpinel @JIoJIaJIu looks great! @jorgeorpinel should we also update the data registry to include the list? |
shcheklein
approved these changes
Mar 7, 2020
Contributor
|
takes too long ... merging this, please make other fixes as a regular update |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #967
Relates:
❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.
🐛 Please make sure to mention
Fix #issue(if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.Please chose to allow us to edit your branch when creating the PR.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏