Skip to content

Regular updates (March 10)#1040

Merged
shcheklein merged 3 commits into
masterfrom
2020-03-09
Mar 14, 2020
Merged

Regular updates (March 10)#1040
shcheklein merged 3 commits into
masterfrom
2020-03-09

Conversation

@jorgeorpinel
Copy link
Copy Markdown
Contributor

@jorgeorpinel jorgeorpinel commented Mar 10, 2020

@shcheklein shcheklein temporarily deployed to dvc-landing-2020-03-09-i7xrewk March 10, 2020 18:53 Inactive
@shcheklein
Copy link
Copy Markdown
Contributor

@jorgeorpinel it's already 22 files, time to review :) ?

@jorgeorpinel
Copy link
Copy Markdown
Contributor Author

@shcheklein OK I'll stop adding changes even when everything has to do with term "flag" and "option" but this needs to wait until the previous regular updates is merged, the file count will be reduced then.

@shcheklein
Copy link
Copy Markdown
Contributor

@jorgeorpinel sounds good! will try to review that one today!

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2020-03-09-i7xrewk March 11, 2020 20:36 Inactive
@jorgeorpinel jorgeorpinel marked this pull request as ready for review March 12, 2020 06:00
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2020-03-09-i7xrewk March 12, 2020 06:20 Inactive
@jorgeorpinel jorgeorpinel requested a review from shcheklein March 12, 2020 08:17
@jorgeorpinel
Copy link
Copy Markdown
Contributor Author

Oops sorry Ivan, I guess this PR stayed big even after merging the previous ones 😢 and I have one last round of updates regarding the "options" term and some missing instances that should've ben done in the recent PRs, but will keep them stashed for a later PR after this.

@jorgeorpinel
Copy link
Copy Markdown
Contributor Author

p.s. ah it did decrease from 22 to 19 files actually! I was seeing 30 when I wrote that ^ OK not so bad then. Still, keeping my current stash for now.

@shcheklein shcheklein merged commit 01ed81c into master Mar 14, 2020
@jorgeorpinel jorgeorpinel deleted the 2020-03-09 branch March 21, 2020 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants