get-started: initial refactoring#1051
Conversation
|
@shcheklein so far this only implements #747 (creates https://dvc-landing-refactor-ge-nouj86.herokuapp.com/doc) but probably a little hacky – see Also if this should be a PR of it's own I can separate it from the remaining changes (Get Started related). |
|
Looks good to me! We should spend a bit of time to think about the landing page content (check other projects). Also, see this discussion that is relevant to your changes in the sidebar.json - #1025 (comment) ... cc @iAdramelk - if we can merge this one before Gatsby migration we might just disallow having any entry w/o index page? But to be honest I would still do redirects if file is missing, and we should be doing this on the middleware level automatically (not relying on sidebar.json). |
This comment has been minimized.
This comment has been minimized.
Working on that ⏳
I don't think so, we have the DOC link in the top menu. But if you prefer that then sure, that wouldn't require the js code changes I did.
If you want to merge this PR soon, please approve it and I'll limit it to this first step for now. |
This comment has been minimized.
This comment has been minimized.
improve its contents
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| "^/doc/?$ /doc/get-started 307", | ||
| "^/doc/user-guide/contributing/?$ /doc/user-guide/contributing/core 307", | ||
| "^/doc/understanding-dvc/?$ /doc/understanding-dvc/collaboration-issues 307", | ||
| "^/doc/changelog/?$ /doc/changelog/0.18 307", |
There was a problem hiding this comment.
I really want to get rid of changelog, make it an external link ... again a special case like a Home button ... we spend time on it again and again
There was a problem hiding this comment.
I thought it was an external link already before? I didn't introduce this in the Gatsby migration, just moved the order of some redirects.
|
Let's try to address the remaining refactoring in #1074 (or further PRs)? Any problems specific to these nav order changes I can still fix here, of course. |
shcheklein
left a comment
There was a problem hiding this comment.
Looks good to me! Make sure that all pages we move we make redirects from their previous locations. Feel free to merge!
Uh oh!
There was an error while loading. Please reload this page.