docs: protected mode is now enabled by-default#1058
Conversation
jorgeorpinel
left a comment
There was a problem hiding this comment.
Good stuff. Some comments below. We can take it over at some point if needed, up to you guys 🙂
Co-Authored-By: Jorge Orpinel <jorgeorpinel@users.noreply.github.com>
Co-Authored-By: Jorge Orpinel <jorgeorpinel@users.noreply.github.com>
Co-Authored-By: Jorge Orpinel <jorgeorpinel@users.noreply.github.com>
|
Will take a fresh look in the morning. Thanks for the reviews! @jorgeorpinel 🙏 |
|
Thank you! Only my comments on public/static/docs/user-guide/large-dataset-optimization.md are pending now, it seems. |
ec32d04 to
14ecc26
Compare
53453ad to
89fa3e4
Compare
|
@jorgeorpinel Addressed all of your comments, please take a look when you'll have time. Thanks! |
Co-Authored-By: Jorge Orpinel <jorgeorpinel@users.noreply.github.com>
89fa3e4 to
73447dc
Compare
jorgeorpinel
left a comment
There was a problem hiding this comment.
A couple more details. Let me try to commit the suggestions myself here on GH 😬
| protect against that, DVC makes hard/soft links read-only, forcing the user to | ||
| use `dvc unprotect` before modifying them. Finally, a 4th "linking" alternative |
There was a problem hiding this comment.
| protect against that, DVC makes hard/soft links read-only, forcing the user to | |
| use `dvc unprotect` before modifying them. Finally, a 4th "linking" alternative | |
| protect against that, DVC makes hardlinks and symlinks links read-only, which requires the user to | |
| use `dvc unprotect` before modifying them. | |
| Finally, a 4th "linking" alternative |
Needs rewrap... Let's see if Restyled can fix this ⏳
There was a problem hiding this comment.
Strange. No Restyled difference 🙁
There was a problem hiding this comment.
Done Ruslan! But there's a formatting check failing and Restyled isn't fixing it? See #1058 (comment)
|
@jorgeorpinel Maybe it is not configured right, I haven't looked deeply in our dvc.org setup. Fixed manually. |
shcheklein
left a comment
There was a problem hiding this comment.
Cool stuff, thanks @efiop and @jorgeorpinel !
treeverse/dvc#3472
❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.
🐛 Please make sure to mention
Fix #issue(if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.Please chose to allow us to edit your branch when creating the PR.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏