install: add pre-commit config#1059
Merged
Merged
Conversation
shcheklein
approved these changes
Mar 16, 2020
| To disable them, you need to **remove** or **edit** those files (i.e. | ||
| `rm .git/hooks/post-checkout`, `vim .git/hooks/pre-commit`). | ||
|
|
||
| ## Using Pre-Commit tool |
Contributor
There was a problem hiding this comment.
Suggested change
| ## Using Pre-Commit tool | |
| ## Using the **pre-commit** tool |
No need for upper case here, I think. Maybe just bold
Comment on lines
+80
to
+81
| DVC provides support for [pre-commit](https://pre-commit.com/) users. To adjust | ||
| `.pre-commit-config.yaml` you could either use |
Contributor
There was a problem hiding this comment.
Suggested change
| DVC provides support for [pre-commit](https://pre-commit.com/) users. To adjust | |
| `.pre-commit-config.yaml` you could either use | |
| DVC provides support to manage Git hooks with [pre-commit](https://pre-commit.com/). | |
| To adjust `.pre-commit-config.yaml` you can either use |
Comment on lines
+106
to
+108
| - `--use-pre-commit-tool` - install pre-commit/pre-push/post-checkout hooks | ||
| into the [pre-commit](https://pre-commit.com/) config | ||
| (`.pre-commit-config.yaml`). |
Contributor
There was a problem hiding this comment.
Suggested change
| - `--use-pre-commit-tool` - install pre-commit/pre-push/post-checkout hooks | |
| into the [pre-commit](https://pre-commit.com/) config | |
| (`.pre-commit-config.yaml`). | |
| - `--use-pre-commit-tool` - installs pre-commit, pre-push, post-checkout Git | |
| hooks into the [pre-commit](https://pre-commit.com/) config file | |
| (`.pre-commit-config.yaml`). |
jorgeorpinel
added a commit
that referenced
this pull request
Mar 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to treeverse/dvc#3406
❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.
🐛 Please make sure to mention
Fix #issue(if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.Please chose to allow us to edit your branch when creating the PR.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏