Get rid of CSV/TSV metrics#1097
Merged
Merged
Conversation
3 tasks
jorgeorpinel
reviewed
Apr 1, 2020
jorgeorpinel
reviewed
Apr 1, 2020
Comment on lines
+23
to
+26
| While any text file can be tracked as a metric file, we recommend using JSON | ||
| formats. DVC provides a way to parse this formats to get to a specific value, if | ||
| the file contains multiple metrics. See the [options](#options) below and | ||
| `dvc metrics diff` for more info. |
Contributor
There was a problem hiding this comment.
Suggested change
| While any text file can be tracked as a metric file, we recommend using JSON | |
| formats. DVC provides a way to parse this formats to get to a specific value, if | |
| the file contains multiple metrics. See the [options](#options) below and | |
| `dvc metrics diff` for more info. | |
| While any text file can be tracked as a metric file, we recommend using JSON | |
| format. DVC provides a way to parse this format to get to a specific value, if | |
| the file contains multiple metric values. See the [options](#options) below, | |
| `dvc metrics show`, and `dvc metrics diff` for more info. |
Notice I added dvc metrics show to the list which I understand is the only subcommand we're sure should keep the ---xpath option. Is this correct?
jorgeorpinel
reviewed
Apr 1, 2020
jorgeorpinel
reviewed
Apr 1, 2020
jorgeorpinel
reviewed
Apr 1, 2020
jorgeorpinel
reviewed
Apr 1, 2020
jorgeorpinel
reviewed
Apr 1, 2020
jorgeorpinel
reviewed
Apr 1, 2020
jorgeorpinel
reviewed
Apr 1, 2020
jorgeorpinel
reviewed
Apr 1, 2020
jorgeorpinel
reviewed
Apr 1, 2020
jorgeorpinel
reviewed
Apr 1, 2020
jorgeorpinel
reviewed
Apr 1, 2020
jorgeorpinel
reviewed
Apr 1, 2020
jorgeorpinel
reviewed
Apr 1, 2020
jorgeorpinel
added a commit
that referenced
this pull request
Apr 1, 2020
jorgeorpinel
added a commit
that referenced
this pull request
Apr 1, 2020
jorgeorpinel
reviewed
Apr 1, 2020
jorgeorpinel
reviewed
Apr 1, 2020
jorgeorpinel
reviewed
Apr 1, 2020
jorgeorpinel
reviewed
Apr 1, 2020
jorgeorpinel
reviewed
Apr 1, 2020
jorgeorpinel
added a commit
that referenced
this pull request
Apr 1, 2020
Contributor
Author
|
@jorgeorpinel I've made another commit with all the changes. PLease take a look. |
jorgeorpinel
reviewed
Apr 7, 2020
Comment on lines
+34
to
+37
| values are: `raw` (default), `json`. It will be saved into the corresponding | ||
| DVC-file, and used by `dvc metrics show` to determine how to handle displaying | ||
| metrics. `raw` means that no additional parsing is applied, and `--xpath` is | ||
| ignored. |
Contributor
There was a problem hiding this comment.
I still see raw mentioned in a few places. I thought we are getting rid of it? Per #1097 (comment)
5 tasks
jorgeorpinel
added a commit
that referenced
this pull request
Apr 7, 2020
jorgeorpinel
approved these changes
Apr 7, 2020
Contributor
jorgeorpinel
left a comment
jorgeorpinel
left a comment
There was a problem hiding this comment.
Just one more thing (about raw metrics) and also #1097 (review) wasn't addressed, everything else is solved so I'm giving approval but please lmk if you'd like me to check again!
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Getting rid of TSV/CSV metrics formats. Part of treeverse/dvc#3409 (comment):