docs: run: update --no-exec description#1225
Merged
Merged
Conversation
efiop
commented
May 3, 2020
Comment on lines
+156
to
+158
| stage is actually executed. DVC will add your outputs to `.gitignore` to | ||
| prevent possible future conflicts. This is useful if, for example, you need to | ||
| build a pipeline (dependency graph) first, and then run it all at once. |
Contributor
Author
There was a problem hiding this comment.
Clearly could be worded/explained better. Suggestions are welcome 🙂
Contributor
There was a problem hiding this comment.
not sure I understand this to prevent possible future conflicts to even suggest improvements :)
3 tasks
shcheklein
suggested changes
May 5, 2020
Contributor
shcheklein
left a comment
shcheklein
left a comment
There was a problem hiding this comment.
Some context/explanation is probably needed unblock this. No need to even change docs - just a plain english what's going on would be suffice.
Contributor
Author
|
Updated the message. It might be considered an implementation detail even, since it is the same thing that it would do without |
shcheklein
approved these changes
May 5, 2020
Contributor
|
Thanks @efiop ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per treeverse/dvc#3729
❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.
🐛 Please make sure to mention
Fix #issue(if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.Please chose to allow us to edit your branch when creating the PR.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏