docs: use --external for add/run#1387
Merged
Merged
Conversation
You are out of testsChoose a plan to resume monitoring your Sites and Pull Requests. If you need help, check the Manage Your Plan and Test Usage guide. |
efiop
changed the title
efiop
force-pushed
the
remove_external_local
branch
from
e724d5a to
d267c49
Compare
efiop
changed the title
--external for add/run
3 tasks
efiop
force-pushed
the
remove_external_local
branch
from
d267c49 to
54706b6
Compare
shcheklein
suggested changes
Jun 3, 2020
jorgeorpinel
reviewed
Jun 3, 2020
jorgeorpinel
reviewed
Jun 3, 2020
Contributor
|
Completion scripts seem updated in https://github.com/iterative/dvc/pull/3929/files but yes I'd just double check all add/run examples involving external data. ✅ |
jorgeorpinel
reviewed
Jun 6, 2020
Comment on lines
+186
to
+188
| - `--external` - allow outputs that are outside of the DVC repository. See | ||
| [Managing External Data](/doc/user-guide/managing-external-data). | ||
|
|
Contributor
There was a problem hiding this comment.
But external dependencies don't require the use of this flag? Hmmm that may be confusing 😕
Contributor
There was a problem hiding this comment.
Moved to treeverse/dvc#1545 (comment) now that this is merged. Thanks
jorgeorpinel
reviewed
Jun 6, 2020
jorgeorpinel
changed the title
--external for add/run--external for add/run
shcheklein
approved these changes
Jun 6, 2020
jorgeorpinel
reviewed
Jun 9, 2020
This was referenced Jun 9, 2020
jorgeorpinel
added a commit
that referenced
this pull request
Jun 10, 2020
jorgeorpinel
changed the title
--external for add/run--external for add/run
20 tasks
Contributor
|
@jorgeorpinel @efiop what is the status of this one? |
Contributor
|
I'll solve conflicts and merge this one now since #1420 was just merged 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per treeverse/dvc#3929
❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.
🐛 Please make sure to mention
Fix #issue(if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.Please choose to allow us to edit your branch when creating the PR.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏