remove: updated to match with core repo#1497
Conversation
* `dvc remove` description updated according to implementation (see treeverse/dvc#4094 for context) * `--outs` description updated according to implementation. * `.gitignore` described in examples. * Removed extra params: `-p`, `-f`. * Removed shorthand for `--outs` (i.e. `-o`). * Updated command description.
jorgeorpinel
left a comment
jorgeorpinel
left a comment
There was a problem hiding this comment.
Thanks @nik123 ! I left a bunch of suggestions. I also think we could use another example because we only have one for a .dvc file, what about removing a stage from dvc.yaml?
Also, not sure what your role is currently so totally OK if this goes beyond the scope of what you can commit to, I can finish it. Just lmk 🙂
Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com>
Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com>
|
As far as understand, there were 2 issues with examples in original code. So I'll try address them both:
I've updated example and now it doesn't require reader to know about linux pipes or
Right now I can't come up with nice, short and simple example for dvc.yaml. If you have an idea for one or think that dvc.yaml example shouldn't necessarily be addressed in this PR, I'm totally fine with it. |
|
No worries, I'll address #2. |
3 participants
Fixes #1490
dvc removedescription updated according to implementation (see dvc remove: inconsistency between implementation and cmd ref dvc#4094 for context)--outsdescription updated according to implementation..gitignoredescribed in examples.Removed extra params:
-p,-f.Removed shorthand for
--outs(i.e.-o).Updated command description.