guide: update types of checksums in dvc.lock doc#1527
Merged
Conversation
3 tasks
This comment has been minimized.
This comment has been minimized.
3 tasks
jorgeorpinel
force-pushed
the
guide/dvclock/GS-md5
branch
from
0de9b53 to
294e76c
Compare
shcheklein
reviewed
Jul 7, 2020
shcheklein
approved these changes
Jul 7, 2020
Contributor
shcheklein
left a comment
shcheklein
left a comment
There was a problem hiding this comment.
good stuff, a minor comment
jorgeorpinel
commented
Jul 8, 2020
| - `outs` (always present): List of <abbr>output</abbr> entries (details below) | ||
| that represent the files or directories tracked with DVC. Typically there is | ||
| only one (but several can be added or combined manually). | ||
| - `deps`: List of <abbr>external dependency</abbr> entries (details below). Only |
Contributor
Author
There was a problem hiding this comment.
deps in .dvc files are always external, right?
Contributor
There was a problem hiding this comment.
@jorgeorpinel No, import-url works with in-repo files too. Not much product sense in that, but still.
Comment on lines
+58
to
+60
| - `wdir` (optional): Working directory for the `outs` and `deps` paths (relative | ||
| to the `.dvc` file's location). If this field is not present explicitly, it | ||
| defaults to `.` (the `.dvc` file's location). |
Contributor
Author
There was a problem hiding this comment.
Do .dvc files even have wdir now? I think Ruslan said it's never generated byt DVC commands but you can put it in manually (thus I called it "optional").
Contributor
There was a problem hiding this comment.
Not only by-hand, but with dvc add --file too.
jorgeorpinel
added a commit
that referenced
this pull request
Jul 9, 2020
shcheklein
pushed a commit
that referenced
this pull request
Jul 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
per #1494 (review)
❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.
🐛 Please make sure to mention
Fix #issue(if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.Please choose to allow us to edit your branch when creating the PR.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏