pipeline: links and examples update for 1.x#1584
Conversation
|
Also, regarding the sub-point in #1255 Next Priorities:
There was a certain bug in one of the examples (private remote) in |
I can't open that link. Why does that stop us from updating the |
|
In fact please find any examples using "dvc pipeline" and update them to "dvc dag" as best as you can @utkarshsingh99. Thanks |
jorgeorpinel
left a comment
jorgeorpinel
left a comment
There was a problem hiding this comment.
So far so good. Just missing updating dvc pipeline from examples all throughout docs.
Please search for "pipeline" everywhere and see if there are any other instances that may need changing to "dag". Thanks
| +---------------------+ | ||
| | src/evaluate.py.dvc | | ||
| +---------------------+ | ||
| ``` |
There was a problem hiding this comment.
Changing the output here because it's a relatively less incorrect output than the previous one.
Unfortunately, the remote still isn't working. I cannot find the output of evaluate.dvc since it doesn't exist. Also, files in src/ are Git-tracked files, so I had to remove them from git. Even after adding all files (dvc add) in src/, dvc dag evaluate.py.dvc does not show the linked files either. I suppose I am missing something and having the remote changed would result in an accurate output. This output is the output I'm currently getting.
There was a problem hiding this comment.
Yeah that's totally wrong 😋 please read the cmd ref at https://dvc.org/doc/command-reference/dag and notice the https://github.com/iterative/example-get-started project has been updated for 1.x already. There are no .dvc stage files, it's all in dvc.yaml. Have you followed the new Get Started at https://dvc.org/doc/start?
There was a problem hiding this comment.
Also you don't need to use a target in dvc dag, just the plan command should be enough... But it will print a diagram which may be too long. If it seems to (too long) just use cat dvc.yaml here as well. Thanks
There was a problem hiding this comment.
Never mind. cat dvc.yaml will bee way too long here also. Let's try dvc dag with the right target please. Lmk if you need help... But do read those refs I shared, hopefully you'll get it from that. Thanks
There was a problem hiding this comment.
Alright, I've updated it with dvc dag evaluate, but it still gave the entire diagram as output.
Because the deps files link all the way back to prepare and featurize.
There was a problem hiding this comment.
OK. Yeah I contradicted myself, sorry... You don't need to use a target in dvc dag. The plan command should show everything by default.
But I think we're gonna have to go with a simple list of stage names like in push, because this diagram is too huge.
The rest of the example will also need updating here, so it makes sense (similar to the changes in https://github.com/iterative/dvc.org/pull/1591/files). Please try to make sure the entire context makes sense and works. Thanks
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Oh okay, I got your point. But a problem arises as stated in #1584(comment).
There was a problem hiding this comment.
I don't see the issue. It's just a matter of updating the rest of the example please.
There was a problem hiding this comment.
This is the other missing point but we can extract into a separate issue. Are you having trouble understanding what I meant here about updating the rest of the example @utkarshsingh99 ? Thanks
This comment has been minimized.
This comment has been minimized.
jorgeorpinel
changed the title
|
A problem in
I have listed the stage names just as a one-line list without the code block, instead of bulleted points. This might not exactly define an 'order' to say that |
This comment has been minimized.
This comment has been minimized.
|
|
||
| ```dvc | ||
| $ dvc pull --with-deps featurize.dvc | ||
| $ dvc pull --with-deps featurize |
There was a problem hiding this comment.
Oops, I missed this change last time.
For now, I don't see any other change. The dvc status command doesn't need change (in my opinion).
I hope I have updated all examples. @jorgeorpinel
Yeah, why status? It doesn't mention
Just in push and pull, as described in this PR's description/scope. |
|
Merging even with this strange CI checks error:
https://www.amazon.com/DevOps-Handbook-World-Class-Reliability-Organizations-ebook/dp/B01M9ASFQ3 is nowhere in these changes. |
2 participants
Continuation of docs: replace
dvc pipelinewithdvc dag#1383 (comment)One of the Next Priorities in DVC 1.x discrepancies docs: Major DVC 1.x discrepancies #1255:
dvc pipelinewithdvc dag#1383 Need to update pipeline links, for now they just redirect to dag. Also push/pull examples.Line 169 inrepro.mdlinks to/doc/tutorial/dagsand previously linked to/doc/tutorial/pipelines. Both these links just redirect todoc/start. Maybe they should have a different link (/doc/start/data-pipelines)?