cmd: update remote modify with --local as needed#1607
Conversation
|
|
||
| ```dvc | ||
| $ dvc remote modify myremote gdrive_client_id <client ID> | ||
| $ dvc remote modify --local myremote gdrive_client_id <client ID> |
There was a problem hiding this comment.
these are fine to be shared, everything for GDrive is more or less fine to share
There was a problem hiding this comment.
True, I didn't think this one through. Updated.
But I think it's safer to leave gdrive_user_credentials_file as --local. Even when the path itself is not THE secret info, in strict terms paths to private files are considered private as well. This is why I included other paths similarly, but in the paragraph for those I say "may contain sensitive user info", depending on each case.
shcheklein
left a comment
shcheklein
left a comment
There was a problem hiding this comment.
Looks great, but we went a bit too far with - some fields are fine to share.
I erred on the side of caution for some (as explained in #1607 (comment)). Or should I roll back adding |
|
@jorgeorpinel left some comments in the PR to revert some |
|
@jorgeorpinel forgot to push? :) |
|
Yes 🤦 Ready... |
| $ dvc remote modify --local myremote password mypassword | ||
| ``` | ||
|
|
||
| > The username, port, and password (may) contain sensitive user info. Therefore, |
There was a problem hiding this comment.
port is not a secret as well
shcheklein
left a comment
shcheklein
left a comment
There was a problem hiding this comment.
one more item ... sorry missed it last time
2 participants
per #1603 (review)
❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.
🐛 Please make sure to mention
Fix #issue(if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.Please choose to allow us to edit your branch when creating the PR.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏