repro 1.x : Updated downstream example and added info for Sequential execution.#1624
Merged
Conversation
shcheklein
reviewed
Jul 24, 2020
jorgeorpinel
suggested changes
Jul 24, 2020
Contributor
jorgeorpinel
left a comment
jorgeorpinel
left a comment
There was a problem hiding this comment.
Correct intentions, thanks! Some details to fix below:
Merged
Contributor
|
Also, the changes per #1572 (review) may also be missing still, but if it's too confusing or doesn't seem to apply now please lmk @sarthakforwet and I'll take care of it. |
jorgeorpinel
suggested changes
Jul 27, 2020
Contributor
jorgeorpinel
left a comment
jorgeorpinel
left a comment
There was a problem hiding this comment.
A few more changes needed ☝️
sarthakforwet
commented
Jul 29, 2020
jorgeorpinel
approved these changes
Jul 31, 2020
Contributor
There was a problem hiding this comment.
Want to take a quick final look before I merge this @shcheklein ? Thanks
And thanks again, @sarthakforwet
shcheklein
reviewed
Jul 31, 2020
shcheklein
reviewed
Jul 31, 2020
shcheklein
approved these changes
Jul 31, 2020
Contributor
shcheklein
left a comment
shcheklein
left a comment
There was a problem hiding this comment.
looks good to me! just a few typos.
Contributor
|
Merged #1648! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR as an outcome of discussion at #1572(review).