--stdin and --all for dvc check-ignore cmd#1675
Merged
Merged
Conversation
Fixes treeverse#1674, Only a draft one.
Contributor
Are you aware of the draft PR functionality in Github @karajan1001 ? 🙂 https://github.blog/2019-02-14-introducing-draft-pull-requests/ |
jorgeorpinel
reviewed
Aug 7, 2020
jorgeorpinel
reviewed
Aug 7, 2020
jorgeorpinel
reviewed
Aug 7, 2020
jorgeorpinel
reviewed
Aug 7, 2020
jorgeorpinel
reviewed
Aug 7, 2020
jorgeorpinel
reviewed
Aug 7, 2020
jorgeorpinel
reviewed
Aug 7, 2020
jorgeorpinel
reviewed
Aug 7, 2020
jorgeorpinel
reviewed
Aug 7, 2020
jorgeorpinel
reviewed
Aug 7, 2020
jorgeorpinel
reviewed
Aug 7, 2020
jorgeorpinel
reviewed
Aug 7, 2020
jorgeorpinel
reviewed
Aug 7, 2020
jorgeorpinel
reviewed
Aug 7, 2020
jorgeorpinel
suggested changes
Aug 7, 2020
Contributor
There was a problem hiding this comment.
I changed a few things. Just a couple things left 🙂
p.s. this will probably have conflicts with #1673 though...
jorgeorpinel
reviewed
Aug 7, 2020
Contributor
|
jorgeorpinel
reviewed
Aug 8, 2020
2 tasks
2 tasks
jorgeorpinel
suggested changes
Aug 10, 2020
Contributor
jorgeorpinel
left a comment
jorgeorpinel
left a comment
There was a problem hiding this comment.
Just one thing left ☝️ Thanks
pared
approved these changes
Aug 11, 2020
Contributor
|
Looks like I'll have to take this one over. |
jorgeorpinel
approved these changes
Aug 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1674 (to match treeverse/dvc/pull/4323).
Only a draft one.
❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.
🐛 Please make sure to mention
Fix #issue(if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.Please choose to allow us to edit your branch when creating the PR.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏