Skip to content

diff: document --hide-missing option#1758

Merged
jorgeorpinel merged 4 commits into
treeverse:masterfrom
pmrowla:diff-hide-missing
Sep 16, 2020
Merged

diff: document --hide-missing option#1758
jorgeorpinel merged 4 commits into
treeverse:masterfrom
pmrowla:diff-hide-missing

Conversation

@pmrowla
Copy link
Copy Markdown
Contributor

@pmrowla pmrowla commented Sep 4, 2020

You may disregard these recommendations if you used the Edit on GitHub button from dvc.org to improve a doc in place.

❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.

🐛 Please make sure to mention Fix #issue (if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.

Please choose to allow us to edit your branch when creating the PR.

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

Documentation changes for treeverse/dvc#4530

@shcheklein shcheklein temporarily deployed to dvc-landing-diff-hide-m-qfjklq September 6, 2020 03:25 Inactive
Comment thread content/docs/command-reference/diff.md Outdated
Comment thread content/docs/command-reference/diff.md Outdated
Comment thread content/docs/command-reference/diff.md Outdated
Copy link
Copy Markdown
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @pmrowla

Other than the comments above, it's kind of confusing to mix the concept of status with diff. Are these the same states that dvc status handles for example? The explanation can get complicated quickly. It would be best to keep that term out of the text in this ref. if possible

  • BTW we should remove it from the --show-md option desc. probably. I can do that later...

@pmrowla
Copy link
Copy Markdown
Contributor Author

pmrowla commented Sep 9, 2020

Still thinking about how to best re-word the docs for this without mixing/confusing dvc status terminology, I'll push an update later today or early tomorrow

* move details to the options section
* avoid using the term `status` to avoid confusion with `dvc status`
@shcheklein shcheklein temporarily deployed to dvc-landing-diff-hide-m-qfjklq September 10, 2020 07:21 Inactive
Comment thread content/docs/command-reference/diff.md Outdated
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-diff-hide-m-qfjklq September 15, 2020 06:32 Inactive
Comment thread content/docs/command-reference/diff.md Outdated
Options `--show-json` and `--show-hash` can be used to modify format and details
of the output produced. See the [Options](#options) and [Examples](#examples)
sections below for more details.
Options `--show-json`, `--show-hash` and `--hide-missing` can be used to modify
Copy link
Copy Markdown
Contributor

@jorgeorpinel jorgeorpinel Sep 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Options `--show-json`, `--show-hash` and `--hide-missing` can be used to modify
Options `--show-json`, `--show-hash`, and `--hide-missing` can be used to modify

May break formatting

Copy link
Copy Markdown
Contributor

@jorgeorpinel jorgeorpinel Sep 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we want to mention --hide-missing here though. Maybe just

--show-json and --show-hash can be used to modify the format of the output

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted these changes to just omit --hide-missing from this part of the dvc diff docs

Copy link
Copy Markdown
Contributor

@jorgeorpinel jorgeorpinel Sep 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. We probably should say "and details" now though...

  • I'll update it separately.

Comment thread content/docs/command-reference/diff.md Outdated
@shcheklein shcheklein temporarily deployed to dvc-landing-diff-hide-m-qfjklq September 16, 2020 07:40 Inactive
Copy link
Copy Markdown
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we've got it now. Thanks for bearing with me @pmrowla

@jorgeorpinel jorgeorpinel merged commit 5c3f2b5 into treeverse:master Sep 16, 2020
jorgeorpinel added a commit that referenced this pull request Sep 16, 2020
per pending items in #1758
@pmrowla pmrowla deleted the diff-hide-missing branch September 17, 2020 04:43
shcheklein pushed a commit that referenced this pull request Sep 17, 2020
* guide: use back quotes in headers
per #1735 (comment)

* guide: use ```yaml instead of yml (consistency)

* guide: capitalize bullet list

* intsall: remove unnecessary line in Linux/snap

* guide: make H3s into expandable sections in x data docs
per #1735 (comment)

* cmd: cosmetic updates to cache.{type} config option descriptions

* cmd: std option descs in diff
per pending items in #1758

* cmd: small impro to diff

* term: review usage of SCM

* cmd: remove redundant wording in add

* cmd: fix format and typo intro by #1779
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants