Skip to content

Remove UrlNotDvcRepoError from exc for dvc.api #1763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shcheklein merged 1 commit into from
Sep 16, 2020
Merged

Remove UrlNotDvcRepoError from exc for dvc.api #1763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions content/docs/api-reference/get_url.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,6 @@ or

## Exceptions

- `dvc.api.UrlNotDvcRepoError` - `repo` is not a DVC project.

Copy link
Copy Markdown
Collaborator Author

@skshetry skshetry Sep 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It returns a whole kinds of exceptions:

  1. PathMissingError
  2. OutputNotFoundError (local) / NoOutputInExternalRepoError (remote repo)
  3. NoRemoteError (local) / NoRemoteInExternalRepoError (remote repo)
  4. Possibly OutputNotFoundError again.

Copy link
Copy Markdown
Collaborator Author

@skshetry skshetry Sep 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But, something to fix on the core repo.

Copy link
Copy Markdown
Contributor

@jorgeorpinel jorgeorpinel Sep 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So is UrlNotDvcRepoError not returned then? What do you recommend the docs say here for now? Whatever best represents the current behavior.

Copy link
Copy Markdown
Collaborator Author

@skshetry skshetry Sep 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave it as-is for now, we should better fix this in the core by throwing only certain sets of exceptions, only ApiError perhaps?

Copy link
Copy Markdown
Contributor

@jorgeorpinel jorgeorpinel Sep 17, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, we already merged this PR where you removed that line. Should we put it back then? Or by "as-is" do you mean having nothing here is OK?

we should better fix this in the core by throwing only certain sets of exceptions, only ApiError perhaps?

Is there a core issue for that?

Thanks

- `dvc.exceptions.NoRemoteError` - no `remote` is found.

## Example: Getting the URL to a DVC-tracked file
Expand Down
2 changes: 0 additions & 2 deletions content/docs/api-reference/open.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,6 @@ streamed, which optimizes memory usage.

- `dvc.exceptions.PathMissingError` - `path` cannot be found in `repo`.

- `dvc.api.UrlNotDvcRepoError` - `repo` is not a DVC project.
Comment thread
jorgeorpinel marked this conversation as resolved.

- `dvc.exceptions.NoRemoteError` - no `remote` is found.

## Example: Use data or models from DVC repos
Expand Down
2 changes: 0 additions & 2 deletions content/docs/api-reference/read.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,6 @@ These are loaded to memory directly (without using any disc space).

- `dvc.exceptions.PathMissingError` - `path` cannot be found in `repo`.

- `dvc.api.UrlNotDvcRepoError` - `repo` is not a DVC project.
Comment thread
jorgeorpinel marked this conversation as resolved.

- `dvc.exceptions.NoRemoteError` - no `remote` is found.

## Example: Load data from a DVC repository
Expand Down