metrics: accept any viable target update#1797
Conversation
| Note, that when using `--targets` it is possible to `diff` files that are not | ||
| specifically marked as metrics. | ||
|
|
There was a problem hiding this comment.
We can avoid this new paragraph by changing the beginning of the --targets option desc from
`--targets <paths>` - limit command scope to these metric files. Using -R
to something like
`--targets <paths>` - limit command scope to these metrics files (supports any file, even when not found as `metrics` in `dvc.yaml`). Using `-R`
There was a problem hiding this comment.
(Notice I also fixed the -R at the end, which should be in back quotes.)
There was a problem hiding this comment.
And problably we should include that info in dvc metrics show --help
jorgeorpinel
left a comment
There was a problem hiding this comment.
Thanks! Left some comments ☝️
If you're unable to further edit this soon, please reopen from a branch directly on this repo instead of a fork so it's easier to take it over.
|
@pared Let's not forget to update |
Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com>
|
Closing in favor of #1809 |
|
Yeah no problem @pared wither way it works but if you open from origin it's easier for me to take it over if needed. |
❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.
🐛 Please make sure to mention
Fix #issue(if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.Please choose to allow us to edit your branch when creating the PR.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
Related to treeverse/dvc#4590