cmd: update version ref.#1814
Merged
Merged
Conversation
jorgeorpinel
suggested changes
Sep 28, 2020
Contributor
There was a problem hiding this comment.
Good so far @imhardikj! Left some specific comments above.
But also, it feels like it needs more updates (keep in mind this is a pretty old doc.) Some possible issues I noticed after a quick readthrough:
- Rewrite "Official release": Not sure why the paragraph starts with "These instructions..." — should start by explaining what the official release (number) is.
- Link to https://www.pypa.io/ ?
- In "Development version", should there be a
pip install...code block that doesn't correspond to the instructions in https://dvc.org/doc/user-guide/contributing/core#development-environment? (Maybe just link there). - "In our case, we use PyInstaller..." should be a note, I think (block quote).
jorgeorpinel
reviewed
Oct 5, 2020
jorgeorpinel
reviewed
Oct 5, 2020
jorgeorpinel
reviewed
Oct 5, 2020
jorgeorpinel
reviewed
Oct 5, 2020
jorgeorpinel
reviewed
Oct 5, 2020
jorgeorpinel
reviewed
Oct 9, 2020
jorgeorpinel
reviewed
Oct 9, 2020
jorgeorpinel
reviewed
Oct 9, 2020
jorgeorpinel
reviewed
Oct 9, 2020
jorgeorpinel
reviewed
Oct 9, 2020
jorgeorpinel
reviewed
Oct 9, 2020
jorgeorpinel
suggested changes
Oct 9, 2020
Contributor
jorgeorpinel
left a comment
There was a problem hiding this comment.
Almost there (I hope).
- A few grammar typos left which are worrying — I have to read everything very carefully to make sure the sentence articles are there which makes it harder to review your changes. Usually this is not something we have to worry about. Please pay 3x attention to this going forward.
- The description of Development version needs a little more work, but that's the last of it.
- I took care of another few things so this is closer to merge.
Thanks @imhardikj
jorgeorpinel
approved these changes
Oct 12, 2020
Contributor
jorgeorpinel
left a comment
There was a problem hiding this comment.
Done! Just a couple small copy edits pending ☝️ (I may take care of them).
Contributor
|
Thanks again @imhardikj, let's keep moving on the remaining cmd ref updates from v0 to v1. I'll keep the reviews more focused and create separate issues if deeper text reviews are needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1635
versionref.