how-to: add stage outputs existing in the WS but missing from dvc.yaml#1840
Merged
Conversation
jorgeorpinel
reviewed
Oct 6, 2020
jorgeorpinel
reviewed
Oct 6, 2020
Contributor
jorgeorpinel
left a comment
jorgeorpinel
left a comment
There was a problem hiding this comment.
Hey @imhardikj a preliminary comment here is that to fix #460 you also need to edit the run and commit references to mention this scenario (and link to the How To for details).
jorgeorpinel
reviewed
Oct 6, 2020
jorgeorpinel
reviewed
Oct 6, 2020
jorgeorpinel
reviewed
Oct 6, 2020
jorgeorpinel
reviewed
Oct 6, 2020
jorgeorpinel
reviewed
Oct 6, 2020
jorgeorpinel
reviewed
Oct 6, 2020
jorgeorpinel
reviewed
Oct 6, 2020
jorgeorpinel
reviewed
Oct 6, 2020
jorgeorpinel
suggested changes
Oct 6, 2020
Contributor
jorgeorpinel
left a comment
jorgeorpinel
left a comment
There was a problem hiding this comment.
Great start. Left a round of feedback ☝️
Please read all the comments before addressing them as some of them are connected. Thanks
jorgeorpinel
reviewed
Nov 3, 2020
jorgeorpinel
reviewed
Nov 3, 2020
jorgeorpinel
reviewed
Nov 3, 2020
jorgeorpinel
reviewed
Nov 3, 2020
jorgeorpinel
reviewed
Nov 3, 2020
jorgeorpinel
reviewed
Nov 3, 2020
jorgeorpinel
reviewed
Nov 3, 2020
jorgeorpinel
reviewed
Nov 3, 2020
jorgeorpinel
reviewed
Nov 3, 2020
jorgeorpinel
reviewed
Nov 3, 2020
jorgeorpinel
suggested changes
Nov 3, 2020
Contributor
jorgeorpinel
left a comment
jorgeorpinel
left a comment
There was a problem hiding this comment.
I'm afraid we're stuck at 90% of the way. We're close but we can't polish the consistency and other details. Details matter. Please not only address my feedback comments one by one in a vacuum, they connect with each other. Do address them individually but then please check the whole context, and that the changes to each doc are consistent with one another. Thanks
jorgeorpinel
reviewed
Nov 4, 2020
jorgeorpinel
reviewed
Nov 4, 2020
jorgeorpinel
reviewed
Nov 4, 2020
jorgeorpinel
reviewed
Nov 4, 2020
Contributor
jorgeorpinel
left a comment
jorgeorpinel
left a comment
There was a problem hiding this comment.
A few final items. We can merge after. Please address @imhardikj. Thanks
jorgeorpinel
approved these changes
Nov 6, 2020
Contributor
|
Done here 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add additional output to a stage without running it again.
Partially resolves #460
Refer - #899 (for How to doc)