Skip to content

Regular updates#1874

Merged
jorgeorpinel merged 13 commits into
masterfrom
jorge
Oct 20, 2020
Merged

Regular updates#1874
jorgeorpinel merged 13 commits into
masterfrom
jorge

Conversation

@jorgeorpinel
Copy link
Copy Markdown
Contributor

@jorgeorpinel jorgeorpinel commented Oct 17, 2020

  • Python params file copy edits/ code formatting
  • Misc. copy edits

@shcheklein shcheklein temporarily deployed to dvc-landing-jorge-ponpxy3udvnh October 17, 2020 21:32 Inactive
IS_BOOL: bool = True
CONST = 5

# All standard variable types are supported

This comment was marked as resolved.

This comment was marked as resolved.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH it's not even ideal to have these notes inside the Python code example IMO but OK, we probably don't want to make a whole new section in the description above to explain all the rules around Python params files.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whole new section in the description above to explain all the rules around Python params files.

that's what I would try to avoid... it's not scalable in this case, it's way easier to get all possibilities from the code to my mind

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. But shouldn't we have a section in https://dvc.org/doc/user-guide/dvc-files-and-directories to describe params files and the supported formats? We could have these notes there (and link from here).

Comment thread content/docs/command-reference/params/index.md
Comment thread content/docs/command-reference/params/index.md
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorge-ponpxy3udvnh October 17, 2020 22:09 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorge-ponpxy3udvnh October 17, 2020 22:09 Inactive
@jorgeorpinel jorgeorpinel changed the title misc updates Regular updates Oct 17, 2020
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorge-ponpxy3udvnh October 17, 2020 22:11 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorge-ponpxy3udvnh October 17, 2020 22:15 Inactive
@jorgeorpinel jorgeorpinel marked this pull request as ready for review October 17, 2020 22:16
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorge-ponpxy3udvnh October 17, 2020 22:18 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorge-ponpxy3udvnh October 17, 2020 22:25 Inactive
Comment thread content/docs/user-guide/basic-concepts/data-artifact.md Outdated
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorge-ponpxy3udvnh October 17, 2020 23:10 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorge-ponpxy3udvnh October 17, 2020 23:12 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorge-ponpxy3udvnh October 20, 2020 01:29 Inactive
@jorgeorpinel jorgeorpinel merged commit 18a0abe into master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants