Skip to content

dvc: still pending 1.x updates (3)#2077

Merged
jorgeorpinel merged 19 commits into
masterfrom
1.0-updates
Jan 7, 2021
Merged

dvc: still pending 1.x updates (3)#2077
jorgeorpinel merged 19 commits into
masterfrom
1.0-updates

Conversation

@jorgeorpinel
Copy link
Copy Markdown
Contributor

This PR is basically for solving conflicts vs. master after #2075 is merged. No more changes are being added.

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-1-0-updates-jt22pp January 7, 2021 00:20 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-1-0-updates-jt22pp January 7, 2021 00:37 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-1-0-updates-jt22pp January 7, 2021 00:42 Inactive
@jorgeorpinel jorgeorpinel marked this pull request as ready for review January 7, 2021 04:19
@jorgeorpinel
Copy link
Copy Markdown
Contributor Author

@shcheklein note that this has the exact same changes as #2074 and #2075 combined. Those were PRs into v1 (in case you didn't notice). This one would actually get deployed when merged. Thanks

p.s. don't worry, that's the only time ever we do this double review as there are no more pending 1.x updates to work in that way.

@shcheklein
Copy link
Copy Markdown
Contributor

Good to go, make sure that it has exactly same changes though :) I trust you on this.

@jorgeorpinel
Copy link
Copy Markdown
Contributor Author

I did double check vs the changes in those PRs while merging conflicts. Thanks 👍

@jorgeorpinel jorgeorpinel merged commit 275a3ec into master Jan 7, 2021
@skshetry skshetry deleted the 1.0-updates branch January 12, 2021 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants