Skip to content

Added verify option to docs#2341

Closed
NigelVanHattum wants to merge 4 commits into
treeverse:masterfrom
NigelVanHattum:NigelVanHattum/pull-5732
Closed

Added verify option to docs#2341
NigelVanHattum wants to merge 4 commits into
treeverse:masterfrom
NigelVanHattum:NigelVanHattum/pull-5732

Conversation

@NigelVanHattum
Copy link
Copy Markdown

Added Docs for verify option to s3 remotes: Pull request

You may disregard these recommendations if you used the Edit on GitHub button from dvc.org to improve a doc in place.

❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.

🐛 Please make sure to mention Fix #issue (if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.

Please choose to allow us to edit your branch when creating the PR.

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

Comment on lines +186 to +188
- `ssl_verify` - whether or not to verify SSL certificates. By default SSL certificates are verified. You can provide the following values:
False - do not validate SSL certificates. SSL will still be used (unless use_ssl is False), but SSL certificates will not be verified.
path/to/cert/bundle.pem - A filename of the CA cert bundle to use.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wrap to 80 chars 🙏

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And let us know when #5732 is approved in order to do a final check here 🙂

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorgeorpinel #5732 has been merged.

@jorgeorpinel jorgeorpinel added the ⌛ status: wait-core-merge Waiting for related product PR merge/release label Mar 31, 2021
@shcheklein
Copy link
Copy Markdown
Contributor

Thanks @NigelVanHattum ! I've merged the restyled version of this PR

@shcheklein shcheklein closed this Apr 1, 2021
@jorgeorpinel
Copy link
Copy Markdown
Contributor

jorgeorpinel commented Apr 2, 2021

Thanks guys. I didn't actually review this closely since the core PR looked like an early WIP at that point... But np, I'll make any copy edits or questions in another PR if needed 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⌛ status: wait-core-merge Waiting for related product PR merge/release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants