Skip to content

ref: copy edit gc -c section#2917

Merged
jorgeorpinel merged 1 commit into
masterfrom
ref/gc/cloud
Nov 12, 2021
Merged

ref: copy edit gc -c section#2917
jorgeorpinel merged 1 commit into
masterfrom
ref/gc/cloud

Conversation

@jorgeorpinel
Copy link
Copy Markdown
Contributor

Closes #154

@jorgeorpinel jorgeorpinel requested a review from efiop October 12, 2021 02:27
@shcheklein shcheklein temporarily deployed to dvc-org-ref-gc-cloud-j5cbmikcn October 12, 2021 02:28 Inactive
@jorgeorpinel jorgeorpinel self-assigned this Oct 12, 2021
@shcheklein
Copy link
Copy Markdown
Contributor

@jorgeorpinel what is the status here?

@jorgeorpinel
Copy link
Copy Markdown
Contributor Author

Just need an approval @shcheklein cc @efiop 🙂

@jorgeorpinel jorgeorpinel requested review from shcheklein and removed request for dberenbaum November 4, 2021 19:13
@shcheklein

This comment has been minimized.

@dberenbaum

This comment has been minimized.

@jorgeorpinel

This comment has been minimized.

If the `--cloud` option is provided, this command deletes unused data from the
[default remote storage](/doc/command-reference/remote/default) **in addition**
to deleting it from the local DVC cache. To specify a DVC remote to delete from,
use `--remote` as well.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if you use --remote without --cloud?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the remote is ignored and it operates locally instead. A bit confusing but this text is correct ATM.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p.s. It should probably fail or give a clearer warning at least. Want me to create an issue about it on the core repo @dberenbaum ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p.p.s. the warning is always the same even with -c:

WARNING: This will remove all cache except items used in the workspace of the current repo.

No mention of cloud/remotes.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, opened treeverse/dvc#6970

@efiop
Copy link
Copy Markdown
Contributor

efiop commented Nov 11, 2021

Oops, sorry for the delay. Was deep into a few things and didn't click on this notification. Please feel free to ping me in PMs if you'll need me urgently.

@jorgeorpinel
Copy link
Copy Markdown
Contributor Author

Hakuna matata

@jorgeorpinel jorgeorpinel merged commit 25d0c98 into master Nov 12, 2021
@jorgeorpinel jorgeorpinel deleted the ref/gc/cloud branch November 12, 2021 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ref: add remote example in gc ref

5 participants