Skip to content

ref: Add plots.auto_open in dvc.config#3101

Merged
daavoo merged 6 commits into
masterfrom
plots-auto-open
Jan 13, 2022
Merged

ref: Add plots.auto_open in dvc.config#3101
daavoo merged 6 commits into
masterfrom
plots-auto-open

Conversation

@daavoo
Copy link
Copy Markdown
Contributor

@daavoo daavoo commented Dec 16, 2021

@daavoo daavoo added ⌛ status: wait-core-merge Waiting for related product PR merge/release C: ref Content of /doc/*-reference labels Dec 16, 2021
@shcheklein shcheklein temporarily deployed to dvc-org-plots-auto-open-gu4tho December 16, 2021 10:00 Inactive
@daavoo daavoo mentioned this pull request Dec 16, 2021
Merged
2 tasks
jorgeorpinel
jorgeorpinel reviewed Dec 17, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy edits (committing)

Comment thread content/docs/command-reference/config.md Outdated
Comment thread content/docs/command-reference/plots/diff.md Outdated
Comment thread content/docs/command-reference/plots/show.md Outdated
@restyled-io restyled-io Bot mentioned this pull request Dec 17, 2021
Merged
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-plots-auto-open-gu4tho December 17, 2021 08:05 Inactive
jorgeorpinel
jorgeorpinel reviewed Dec 17, 2021
View reviewed changes
Comment thread content/docs/command-reference/config.md Outdated
Comment on lines +284 to +285
- `plots.auto_open` - if `true`, DVC will automatically open the HTML
generated by `dvc plots` commands in a browser. `false` by default
Copy link
Copy Markdown
Contributor

@jorgeorpinel jorgeorpinel Dec 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: Will this apply to dvc exp show --html (or whatever the final command for PCPs is) ? If so maybe add a check box to update this in #3105 at some point).

This comment was marked as resolved.

Sign in to view

Copy link
Copy Markdown
Contributor

@jorgeorpinel jorgeorpinel Jan 4, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So now that #3098 was merged first maybe we should address #3098 (review) here?

@jorgeorpinel jorgeorpinel mentioned this pull request Dec 17, 2021
Merged
1 task
@restyled-io @restyled-commits
Restyled by prettier (#3109)
143a8df 
Co-authored-by: Restyled.io <commits@restyled.io>
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-plots-auto-open-gu4tho December 17, 2021 08:10 Inactive
jorgeorpinel
jorgeorpinel reviewed Dec 17, 2021
View reviewed changes
Comment thread content/docs/command-reference/config.md Outdated
@jorgeorpinel jorgeorpinel had a problem deploying to dvc-org-plots-auto-open-gu4tho December 17, 2021 08:11 Failure
@daavoo daavoo mentioned this pull request Dec 17, 2021
Merged
1 task
@daavoo daavoo removed the ⌛ status: wait-core-merge Waiting for related product PR merge/release label Jan 3, 2022
@daavoo daavoo requested a review from jorgeorpinel January 3, 2022 15:08
@daavoo daavoo self-assigned this Jan 3, 2022
jorgeorpinel
jorgeorpinel approved these changes Jan 5, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorgeorpinel any updates? can we merge this?

Yep. I did not intend to block this merge and it's approved already. I did just leave some more suggestions but it's mergeable.

Thanks again for the contribution and addressing all the feedback too, @daavoo !

@shcheklein shcheklein temporarily deployed to dvc-org-plots-auto-open-gu4tho January 13, 2022 16:04 Inactive
@daavoo daavoo merged commit 8421b97 into master Jan 13, 2022
@daavoo daavoo deleted the plots-auto-open branch January 13, 2022 16:06
iesahin pushed a commit that referenced this pull request Apr 11, 2022
@daavoo @jorgeorpinel @iesahin
ref: Add plots.auto_open in dvc.config (#3101)
fbe27dc 
* ref: Add `plots.auto_open` in `dvc.config`

* ref: copy edits around plots --open

* Mention auto_open in pcp

Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jorgeorpinel jorgeorpinel jorgeorpinel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@daavoo daavoo

Labels

C: ref Content of /doc/*-reference

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@daavoo @jorgeorpinel @shcheklein