start: use exp init instead of stage add#3196
Merged
Merged
Conversation
3 tasks
shcheklein
reviewed
Jan 19, 2022
shcheklein
reviewed
Jan 19, 2022
shcheklein
reviewed
Jan 22, 2022
shcheklein
reviewed
Jan 22, 2022
shcheklein
reviewed
Jan 22, 2022
shcheklein
suggested changes
Jan 22, 2022
Contributor
shcheklein
left a comment
shcheklein
left a comment
There was a problem hiding this comment.
A bit of cleanup, otherwise good to go I think
Contributor
Author
|
Updated per your review. Thanks @shcheklein |
shcheklein
reviewed
Jan 26, 2022
| > use isolated from the rest of your system. This prevents version conflicts. | ||
| A typical machine learning project has data, a set of scripts that train a | ||
| model, a bunch of hyperparameters that tune training and models, and outputs | ||
| metrics and plots to evaluate the models. DVC makes certain assumptions about |
Contributor
There was a problem hiding this comment.
one more thing reading this. "DVC makes assumptions" is too strong (like DVC is an opinionated framework while it's not). It's only dvc exp init has defaults, right?
Contributor
Author
There was a problem hiding this comment.
Revised that phrase. Thank you. @shcheklein PTAL.
shcheklein
suggested changes
Jan 26, 2022
Contributor
shcheklein
left a comment
shcheklein
left a comment
There was a problem hiding this comment.
looks go to me, thanks @iesahin !
One small but important change in the init description that I think we should make.
shcheklein
reviewed
Feb 2, 2022
shcheklein
reviewed
Feb 2, 2022
| A typical machine learning project has data, a set of scripts that train a | ||
| model, a bunch of hyperparameters that tune training and models, and outputs | ||
| metrics and plots to evaluate the models. `dvc exp init` has sane defaults about | ||
| the names of these elements to initialize a project: |
shcheklein
approved these changes
Feb 2, 2022
Co-authored-by: Ivan Shcheklein <shcheklein@gmail.com>
jorgeorpinel
had a problem deploying
to
dvc-org-iesahin-start-e-myzshv
jorgeorpinel
approved these changes
Feb 2, 2022
jorgeorpinel
had a problem deploying
to
dvc-org-iesahin-start-e-myzshv
iesahin
pushed a commit
that referenced
this pull request
Apr 11, 2022
* use exp init instead of stage add * into -> with in the title * rephrase into -> with + using * modify -> tune * describes -> specifies * makes assumptions -> has sane defaults * h3 -> h2 * Update content/docs/start/experiments.md Co-authored-by: Ivan Shcheklein <shcheklein@gmail.com> * Apply suggestions from code review Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com> Co-authored-by: Ivan Shcheklein <shcheklein@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one updates the project setup instructions in dvc.org/start/experiments
Related #3051