Add TOML version where YAML version also mentioned for dvc#7253#3361
Merged
Conversation
7 tasks
syntapy
changed the title
dberenbaum
added
the
⌛ status: wait-core-merge
Contributor
|
Draft-ed since treeverse/dvc#7468 is still a draft. Please mark ready to review when the core PR is approved. Thanks |
Contributor
|
Hi. Seems like treeverse/dvc#7468 is inactive. Should we keep this still? Thanks |
Contributor
Author
|
@jorgeorpinel I've been (slowly) working on an upstream pr to finish the one in dvc, as per comment. So yeah, I'm still on it! |
shcheklein
removed
the
⌛ status: wait-core-merge
Contributor
Author
|
@jorgeorpinel ready to be looked at! |
daavoo
approved these changes
Aug 8, 2022
jorgeorpinel
reviewed
Aug 8, 2022
Comment on lines
49
to
51
| The default **parameters file** name is `params.yaml`, but any other YAML 1.2, | ||
| JSON, TOML, or [Python](#examples-python-parameters-file) files can be used | ||
| JSON, TOML 1.0, or [Python](#examples-python-parameters-file) files can be used | ||
| additionally (listed under `params:` as shown in the sample above). These files |
Contributor
There was a problem hiding this comment.
Thanks! There's another instance we missed in https://dvc.org/doc/command-reference/metrics#supported-file-formats
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slight edit to be made per treeverse/dvc#7468
❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.
🐛 Please make sure to mention
Fix #issue(if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.Please choose to allow us to edit your branch when creating the PR.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏