start: bi-trail reorg#3455
Conversation
| @@ -0,0 +1,278 @@ | |||
| --- | |||
| title: 'Get Started: Metrics, Parameters, and Plots' | |||
There was a problem hiding this comment.
QQ - is it the same file as we had before or do we have some / any changes here?
There was a problem hiding this comment.
Same file. I did minimum content changes in this PR
|
I didn't change any content, this is just a showcase for organization.
…On Wed, Apr 20, 2022 at 8:29 PM Ivan Shcheklein ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In content/docs/start/data/metrics-parameters-plots.md
<#3455 (comment)>:
> @@ -0,0 +1,278 @@
+---
+title: 'Get Started: Metrics, Parameters, and Plots'
QQ - is it the same file as we had before or do we have some / any changes
here?
—
Reply to this email directly, view it on GitHub
<#3455 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADUJFVY2YYDK2UXBDJYMHLVGA5G3ANCNFSM5T4PMI3A>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
shcheklein
left a comment
shcheklein
left a comment
There was a problem hiding this comment.
Looks go to me.
Do we need redirects?
Can we introduce some small corrections in the index page to explain the new structure and help people navigate? (please let's try to do it quick, non invasive :) )
|
We need redirects. I didn't change any content, will review briefly. Did you deploy this one yourself? (I mean, did you see the actual site?) |
|
No, I didn't see actual site. I was reviewing MD files here. |
Gatsby Cloud Build Reportdvc.org 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 3m |
|
I'll merge #3050 to this and merge these together. Could you review this one? @jorgeorpinel |
jorgeorpinel
changed the title
| "label": "Data Management", | ||
| "source": "data/index.md", | ||
| "children": [ |
There was a problem hiding this comment.
The only issue with adding this middle click-level is that it's possible to "get lost" in the navigation. Example: I click Get Started and read the general index. Then I only open the Data Management element in the nav (click the little arrow) *without opening its index page* and see that there's pages inside. I then assume the content starts in the first sub-page (Accessing Data) and click on that. I have now missed all of the basic info on data mgmt. Cc @shcheklein
Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com>
Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com>
Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com>
Co-authored-by: Restyled.io <commits@restyled.io>
|
Would you take a look at the deployment once more or could I merge this now? @shcheklein @jorgeorpinel |
|
I renamed the directory and checked the links and redirects. I think this is ready to merge now. @jorgeorpinel @shcheklein |
| "^/doc/start/metrics-parameters-plots(/.*)?$ /doc/start/data-management/metrics-parameters-plots$1 302", | ||
| "^/doc/start/sharing-data-and-model-files$ /doc/start/data-and-model-versioning#storing-and-sharing 303", |
There was a problem hiding this comment.
Unrelated: I'm not sure why there are 302s and 303s in this file tbh. I think it should mostly be 302 except for a group near the top of utility redirects (e.g. data.dvc.org -> S3 bucket read)
|
p.s. @iterative/websites this needs deploying to prod please 🙂 |
4 participants
This is the second (or third) candidate for GS reorganization:
Compare w/ #3444
This creates another level in the sidebar, moves
versioning->data/index, makesaccessing,pipelines,metrics-params-plotschildren ofdata/. Movesexperiments.mdtoexperiments/index.mdand addsvisualizationfrom #3050 as a child toexperiments.