#306 dvc-file-format updated#383
Merged
Merged
Conversation
shcheklein
reviewed
May 25, 2019
shcheklein
suggested changes
May 25, 2019
Contributor
shcheklein
left a comment
shcheklein
left a comment
There was a problem hiding this comment.
Good stuff! Left some comments to address. Thanks!
shcheklein
reviewed
May 27, 2019
shcheklein
reviewed
May 27, 2019
shcheklein
suggested changes
May 27, 2019
Contributor
shcheklein
left a comment
shcheklein
left a comment
There was a problem hiding this comment.
Looks great!
I left a few comments to address.
Also, please, let's mention in dvc add/import/run command reference that when file is overwritten it does not preserve comments/meta for now.
Thanks again, for helping with this.
shcheklein
reviewed
May 28, 2019
shcheklein
reviewed
May 28, 2019
shcheklein
reviewed
May 28, 2019
shcheklein
suggested changes
May 28, 2019
Contributor
shcheklein
left a comment
shcheklein
left a comment
There was a problem hiding this comment.
looks really great! just a few minor stylistic changes to address. Thanks!
shcheklein
approved these changes
May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #306
meta entry updated and also mentioned that comments are persistent now.