Skip to content

dvcignore: add docs related to global dvcignore#3950

Closed
meshde wants to merge 4 commits into
treeverse:mainfrom
meshde:global-dvcignore-file
Closed

dvcignore: add docs related to global dvcignore#3950
meshde wants to merge 4 commits into
treeverse:mainfrom
meshde:global-dvcignore-file

Conversation

@meshde
Copy link
Copy Markdown

@meshde meshde commented Sep 15, 2022

Documentation for changes made by treeverse/dvc#8280

@shcheklein
Copy link
Copy Markdown
Contributor

Thanks @meshde ! 🙏

Tests (linters) are failing on prettier:

$ prettier --check '**/*.{js,jsx,md,tsx,ts,json}'
Checking formatting...

@jorgeorpinel @rogermparent @yathomasi do you know why there is no Restyled PR and what it is the recommended workflow in these cases? can we enabled it back somehow with an explicit approvals, etc?

@meshde would you mind to install pre-commit (running yarn locally should do the trick) and amend the commit please?

@meshde
Copy link
Copy Markdown
Author

meshde commented Sep 16, 2022

@shcheklein thank you for your review!

The pre-commit hook had actually run for me. The failing lint check was not related to this PR's changes and was failing on the main branch as well at the time I had initially raised the PR.

The check seems to be passing on the main branch now, so updating this PR with the main branch seems to have made the checks pass here as well!

@shcheklein shcheklein added the ⌛ status: wait-core-merge Waiting for related product PR merge/release label Sep 16, 2022
@jorgeorpinel
Copy link
Copy Markdown
Contributor

do you know why there is no Restyled PR and what it is the recommended workflow in these cases?

Restyled no longer supports 3rd party PRs because it's a security vulnerability.

Glad that the checks here are OK now though.

@jorgeorpinel jorgeorpinel added the A: docs Area: user documentation (gatsby-theme-iterative) label Sep 20, 2022
@jorgeorpinel
Copy link
Copy Markdown
Contributor

My initial impression is that the table is great (similar to the one in dvc config) but adding a new header and the new bullet list may be too much. We can probably summarize this a lot. Please ping us again once treeverse/dvc#8280 is approved and we'll help get it there. Thanks

@shcheklein shcheklein closed this Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A: docs Area: user documentation (gatsby-theme-iterative) ⌛ status: wait-core-merge Waiting for related product PR merge/release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants