bulleted points end with : or .#495
Conversation
|
https://dvc.org/doc/understanding-dvc/collaboration-issues it still has "?" at end of bulleted points. Shall I change or keep it the same. Now, all of the bulleted points end with ":" or "." |
shcheklein
left a comment
There was a problem hiding this comment.
before we do this, let's first come up with a set or rules
jorgeorpinel
left a comment
There was a problem hiding this comment.
Good start, thanks! There's many more bullet lists in the docs though.
Let's see if we can agree to the rules I suggested in #491 (comment) and then keep going here 🙂
|
The docs containing bulleted points are:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Do you see my review now @naba7 ? My bad. I think I didn't submit it before so you couldn't see it.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
@naba7 another thing missing here is to review all the docs. I see many files that still have bullets ending in ;, for example. Search files for regex ^\-.*\n?.*; like this:
This comment has been minimized.
This comment has been minimized.
jorgeorpinel
left a comment
There was a problem hiding this comment.
Thanks for the updates. Here are some comments on the changes.
Also, there are more bullet lists that need review outside of static/docs/commands-reference/ for example in static/docs/understanding-dvc/resources.md and at least 3 more files. Please search all of static/docs/ For example searching for this basic regex ^\-.* in all files will show you every single first-level bullet.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Yes great work, thanks a lot @naba7! I hope I'm not being to demanding but here are a few last things:
- You missed a bullet list in static/docs/user-guide/autocomplete.md (lines 46-8).
- Several bullet lists in static/docs/user-guide/dvc-file-format.md start with lower case but I think they should start with Capital letter (not sure, please double agains check the rules we agreed).
- The last 2 bullets of the list in static/docs/user-guide/dvc-files-and-directories.md shuold not end in period
.. Please use text:- `.dvc/updater.lock` - lock file for `.dvc/updater` - `.dvc/lock` - lock file for the whole DVC project
Please also address the comments below:
|
Thanks @jorgeorpinel Yes, my bad! I have changed those. Please take a look! |
jorgeorpinel
left a comment
There was a problem hiding this comment.
All done! Thanks again @naba7
@shcheklein I'm approving the changes I requested in my review.
shcheklein
left a comment
There was a problem hiding this comment.
thanks @naba7 and @jorgeorpinel !

Fixes #491