Skip to content

docs: regular updates (late Oct) #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shcheklein merged 24 commits into from
Oct 28, 2019
Merged

docs: regular updates (late Oct) #725

shcheklein merged 24 commits into from
Oct 28, 2019

Conversation

@jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented Oct 23, 2019 •
edited
Loading

Addresses #720
Fixes #701
Fixes #698
Fixes #736
Addresses #702

@jorgeorpinel jorgeorpinel added A: docs Area: user documentation (gatsby-theme-iterative) user-guide labels Oct 23, 2019
@shcheklein shcheklein temporarily deployed to dvc-org-pr-725 October 23, 2019 01:33 Inactive
shcheklein
shcheklein reviewed Oct 23, 2019
View reviewed changes
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-725 October 23, 2019 23:21 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-725 October 25, 2019 17:09 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-725 October 25, 2019 17:26 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-725 October 25, 2019 17:37 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-725 October 25, 2019 18:24 Inactive
shcheklein
shcheklein reviewed Oct 25, 2019
View reviewed changes
shcheklein
shcheklein reviewed Oct 25, 2019
View reviewed changes
shcheklein
shcheklein suggested changes Oct 25, 2019
View reviewed changes
Copy link
Contributor

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all look good, just a few comments

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-725 October 25, 2019 23:32 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-725 October 26, 2019 00:31 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-725 October 26, 2019 01:23 Inactive
@jorgeorpinel jorgeorpinel mentioned this pull request Oct 26, 2019
Closed
@jorgeorpinel jorgeorpinel changed the title docs: regular updates (late Oct) [WIP] docs: regular updates (late Oct) Oct 26, 2019
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-725 October 26, 2019 04:16 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-725 October 27, 2019 23:05 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-725 October 28, 2019 01:02 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-725 October 28, 2019 01:06 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-725 October 28, 2019 01:22 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-725 October 28, 2019 06:29 Inactive
shcheklein
shcheklein reviewed Oct 28, 2019
View reviewed changes
shcheklein
shcheklein reviewed Oct 28, 2019
View reviewed changes
shcheklein
shcheklein reviewed Oct 28, 2019
View reviewed changes
shcheklein
shcheklein suggested changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the last a few comments, suggestions :)

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-725 October 28, 2019 23:19 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-725 October 28, 2019 23:20 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-725 October 28, 2019 23:25 Inactive
@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Oct 28, 2019

Please note I also just commited d557fe1 @shcheklein. Not sure how you'll feel about this.

@shcheklein
Copy link
Contributor

shcheklein commented Oct 28, 2019

@jorgeorpinel tbh, I think it's a signal that some refactoring is needed when we have two of three notes in a row. I would try to avoid them in the first place. Otherwise I'm totally fine with those delimiters, though don't quire understand if they are here to make it easier to maintain these files and avoid mistakes or there are some other reasons?

@shcheklein shcheklein merged commit d1f296e into master Oct 28, 2019
@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Oct 29, 2019

don't quire understand if they are here to make it easier to maintain these files

The reason for those comments is so the quotes are not merges into one when the Markdown is rendered. This way there is an empty line between notes (signaling these are different topics).

@weekly-digest weekly-digest bot mentioned this pull request Nov 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@shcheklein shcheklein shcheklein approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A: docs Area: user documentation (gatsby-theme-iterative)

Projects

None yet

Milestone

No milestone

2 participants

@jorgeorpinel @shcheklein