-
Notifications
You must be signed in to change notification settings - Fork 409
gdrive support #833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gdrive support #833
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -143,6 +143,7 @@ Install requirements for whatever remotes you are going to test: | |
| $ pip install -e ".[s3]" | ||
| $ pip install -e ".[gs]" | ||
| $ pip install -e ".[azure]" | ||
| $ pip install -e ".[gdrive]" | ||
| $ pip install -e ".[ssh]" | ||
|
jorgeorpinel marked this conversation as resolved.
|
||
| # or | ||
| $ pip install -e ".[all]" | ||
|
|
@@ -250,6 +251,26 @@ $ export AZURE_STORAGE_CONNECTION_STRING="DefaultEndpointsProtocol=http;AccountN | |
|
|
||
| <details> | ||
|
|
||
| ### Click for Google Drive testing instructions | ||
|
|
||
| ❗Do not share Google Drive access token with anyone to avoid unauthorized usage | ||
| of your Google Drive. | ||
|
Comment on lines
+256
to
+257
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Continuation of #833 (review) But is it DVC's responsibility to alert about G Drive security? If not, maybe just a note (md quote starting with Regardless, please use this text:
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it's good to have this for GD - it not a common knowledge with all these tokens involved into GD.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. quotes with But tbh - I'm fine with all of these option. Jorge, I think we'll let you decide on this :)
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I agree notes with in this case though, while I like having the note, I do see it as a side-note that could be completely omitted and not something that DVC can really control. So for that reason and since we don't really have emojis ATM, I'm going to take it back to a Should we open an issue to apply some basic emoji symbols throughout with some consistency though? This could be a nice improvement to our docs.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Addressed in d9ab97f |
||
|
|
||
| To avoid tests flow interruption by manual login, do authorization once and | ||
| backup obtained Google Drive access token which is stored by default under | ||
| `.dvc/tmp/gdrive-user-credentials.json`. Restore `gdrive-user-credentials.json` | ||
| from backup for any new DVC repo setup to avoid manual login. | ||
|
|
||
| Or add this to your env (use encryption for CI setup): | ||
|
|
||
| ```dvc | ||
| $ export GDRIVE_USER_CREDENTIALS_DATA='CONTENT_of_gdrive-user-credentials.json' | ||
| ``` | ||
|
|
||
| </details> | ||
|
|
||
| <details> | ||
|
|
||
| ### Click for HDFS testing instructions | ||
|
|
||
| Tests currently only work on Linux. First you need to set up passwordless ssh | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.