Skip to content

Regular doc updates (early Dec)#846

Merged
jorgeorpinel merged 21 commits into
masterfrom
jorgeorpinel
Dec 12, 2019
Merged

Regular doc updates (early Dec)#846
jorgeorpinel merged 21 commits into
masterfrom
jorgeorpinel

Conversation

@jorgeorpinel
Copy link
Copy Markdown
Contributor

@jorgeorpinel jorgeorpinel commented Dec 9, 2019

@shcheklein shcheklein temporarily deployed to dvc-org-pr-846 December 9, 2019 18:28 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-846 December 9, 2019 19:58 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-846 December 9, 2019 20:46 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-846 December 9, 2019 23:08 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-846 December 9, 2019 23:13 Inactive
Comment thread src/Diagram/index.js Outdated
Comment thread static/docs/command-reference/remote/add.md Outdated
Comment thread static/docs/command-reference/remote/add.md
Comment thread static/docs/command-reference/remote/list.md
Comment thread static/docs/command-reference/remote/modify.md Outdated
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-846 December 9, 2019 23:26 Inactive
Copy link
Copy Markdown
Contributor

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments, good to merge

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-846 December 10, 2019 01:25 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-846 December 10, 2019 01:35 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-846 December 10, 2019 01:38 Inactive
@jorgeorpinel

This comment has been minimized.

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-846 December 10, 2019 18:50 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-846 December 10, 2019 19:16 Inactive
@jorgeorpinel jorgeorpinel changed the title [WIP] regular doc updates Regular doc updates (early Dec) Dec 10, 2019
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-846 December 10, 2019 22:54 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-846 December 10, 2019 23:47 Inactive
Comment thread pages/api/comments.js Outdated
Comment thread static/docs/command-reference/config.md Outdated
Comment thread static/docs/command-reference/remote/add.md Outdated
Comment thread static/docs/command-reference/remote/add.md Outdated
Comment thread static/docs/user-guide/dvc-files-and-directories.md
Copy link
Copy Markdown
Contributor

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. A few minor comments/questions.

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-846 December 11, 2019 23:33 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-846 December 11, 2019 23:51 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-846 December 11, 2019 23:56 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-846 December 12, 2019 00:06 Inactive
Comment thread .github/PULL_REQUEST_TEMPLATE.md Outdated
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-846 December 12, 2019 00:11 Inactive
Copy link
Copy Markdown
Contributor

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! feel free to merge!

@jorgeorpinel
Copy link
Copy Markdown
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants