Skip to content

test: link-check against merge base #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shcheklein merged 2 commits into from
Feb 7, 2020
Merged

test: link-check against merge base #979

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c8b9a4
test: link-check against merge base
casperdcl Feb 7, 2020
17bdb0e
test: link-check diff additions only
casperdcl Feb 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/link-check-git-diff.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
#!/usr/bin/env bash
set -euxo pipefail
$(dirname "$0")/link-check.sh <(git diff origin/master -U0)
$(dirname "$0")/link-check.sh <(git diff $(git merge-base HEAD origin/master) -U0 | grep '^\+')
Copy link
Copy Markdown
Contributor

@jorgeorpinel jorgeorpinel Feb 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can just use lint-staged (used/configured in package.json) to sent the staged files into this script @casperdcl ?

Copy link
Copy Markdown
Contributor Author

@casperdcl casperdcl Feb 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't because that would affect the pre-commit hook

Copy link
Copy Markdown
Contributor Author

@casperdcl casperdcl Feb 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(and we can't assume devs have the prereqs to run the checks)