plot axis labels displaying "<DVC_METRIC_X_TITLE>"

[elleobrien]

I'm using pre-release v. 1.0.0a10+568333. When I run

dvc plots show estimators.csv or dvc plots diff --target estimators.csv, I'm getting the axis labels from the vega-lite template, not my *.csv file. Even if I use the -x and '-y flags, nothing happens. This didn't happen previously; did we change the flag to assign axis titles?

[efiop]

Related #3968.

@andronovhopf Could you show your template, please? Have you adjusted it or is it the stock one?

[elleobrien]

It's the stock template!

[efiop]

@andronovhopf Could you delete .dvc/plots and run your command again, please?

[elleobrien]

Yeah that worked, now my plots are looking as expected

[efiop]

@andronovhopf Nice! Ok, looks like we've changed the template(or template related logic, can't put my finger on anything specific yet) at some point during the pre-release, so you had old templates from that time that don't really work with the new dvc version. Do you remember when you've generated those .dvc/plots ? If it is in one of the private projects, please let me know, I'll double-check it myself to make sure there is nothing seriously bad going on.

[efiop]

@andronovhopf Btw, the plots you've shared differ a bit, is that expected?

[elleobrien]

So the project is in this public repo: it was working last week, so we can check how the .dvc/plots changed https://github.com/andronovhopf/prettypretty

…

On Tue, Jun 9, 2020 at 2:18 PM Ruslan Kuprieiev ***@***.***> wrote: @andronovhopf <https://github.com/andronovhopf> Nice! Ok, looks like we've changed the template(or template related logic, can't put my finger on anything specific yet) at some point during the pre-release, so you had old templates from that time that don't really work with the new dvc version. Do you remember when you've generated those .dvc/plots ? If it is in one of the private projects, please let me know, I'll double-check it myself to make sure there is nothing seriously bad going on. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3997 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHCXB5F66GJVPTZAB7AMVZ3RV2RJ3ANCNFSM4NZW6ZYA> .

[efiop]

@andronovhopf Yep, we've changed the anchors since then https://github.com/andronovhopf/prettypretty/commit/e231b37ce93e43154a201da6d97b964f6dfb6ab2#diff-b70c67e8b4c164d2c005e4dcd35b4552

and it has caused this issue.

So nothing too serious here, it was caused by #3948 . No action required here, I don't think.

[elleobrien]

haha was just commenting to send you that exact screenshot. looks good!

[efiop]

Looks like it is resolved. Closing.