Skip to content

analytics: fix mac not sending reports #10026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
efiop merged 4 commits into from
Oct 16, 2023
Merged

analytics: fix mac not sending reports #10026

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4cff2bd
analytics: fix mac not sending reports
Oct 16, 2023
59ad988
limit analytics change to mac
Oct 16, 2023
b0df29c
Merge branch 'main' into debug-analytics
Oct 16, 2023
9ab6e4e
analytics: stop using popen on mac
Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions dvc/daemon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import inspect
import logging
import os
import platform
import sys
from subprocess import Popen # nosec B404
from typing import List
Expand Down Expand Up @@ -93,13 +92,8 @@ def _spawn_posix(cmd, env):
sys.stderr.close()
os.closerange(0, 3)

if platform.system() == "Darwin":
# workaround for MacOS bug
# https://github.com/iterative/dvc/issues/4294
_popen(cmd, env=env).communicate()
else:
os.environ.update(env)
main(cmd)
os.environ.update(env)
main(cmd)

os._exit(0) # pylint: disable=protected-access

Expand Down