Skip to content

Patch: shared parser target content. #2111

Merged
efiop merged 4 commits into
treeverse:masterfrom
sanidhyamangal:master
Jun 11, 2019
Merged

Patch: shared parser target content. #2111
efiop merged 4 commits into
treeverse:masterfrom
sanidhyamangal:master

Conversation

@sanidhyamangal
Copy link
Copy Markdown
Contributor

@sanidhyamangal sanidhyamangal commented Jun 10, 2019

  • Have you followed the guidelines in our
    Contributing document?

  • Does your PR affect documented changes or does it add new functionality
    that should be documented? If yes, have you created a PR for
    dvc.org documenting it or at
    least opened an issue for it? If so, please add a link to it.


@shcheklein, As per our discussion I am patching the content of target in shared parser kindly review it.

treeverse/dvc.org#416

@efiop
Copy link
Copy Markdown
Contributor

efiop commented Jun 10, 2019

@sanidhyamangal Your patch doesn't pass coding style checks. Check out our contributing guide: https://dvc.org/doc/user-guide/contributing . In short, this time you'll simply need to

pip install black
black dvc/

In the contrib guide, there is a note about installing pre-commit hook to check all of this for you when you are creating the commit on your machine.

Copy link
Copy Markdown
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sanidhyamangal !

@efiop efiop merged commit 7f73c6f into treeverse:master Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants